Re: [PATCH] RFC: commit: add a commit.all-ignore-submodules config option

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jan 7, 2020, 00:05 UTC
Message-ID: <20200107000551.GE92456@google.com>
In-Reply-To: <CAMxuvayT8FtovVnWU4bjQCP26drN37yuPG2+G2jAUsm0Ns_AYA@mail.gmail.com>

Marc-André Lureau wrote:

> On Sat, Jan 4, 2020 at 4:45 AM Jonathan Nieder <jrnieder@gmail.com> wrote:
>> Marc-André Lureau wrote:

Show 10 quoted lines

>>> One of my most frequent mistake is to commit undesired submodules
>>> changes when doing "commit -a", and I have seen a number of people doing
>>> the same mistake in various projects. I wish there would be a config to
>>> change this default behaviour.
>>
>> Can you say more about the overall workflow this is part of?  What
>> causes the submodules to change state in the first place here?
>
> The most common case is, I guess, when you work on different branches
> that have different (compatible) versions of the submodules.

Ah! This is because "git checkout" defaults to --no-recurse-submodules, which is a terrible default.

Does "git config submodule.recurse true" help? If so, we can look into which it would take to flip that default.

Thanks, Jonathan