Re: [RFC] xl command for visualizing recent history

From: Matthew DeVore <matvore@comcast.net>
Date: Jan 3, 2020, 02:51 UTC
Message-ID: <20200103025115.GA6521@comcast.net>
In-Reply-To: <20191031003929.GA22855@google.com>

Sorry for going dark on this topic. I'm still interested in working on this. I've gotten so much feedback that I fear I won't be able to respond to all of it in a thorough manner, but if that's the case, rest assured I have read your feedback at least twice (including that from Phillip and Dscho) and will take it into consideration going forward.

On Wed, Oct 30, 2019 at 05:39:29PM -0700, Emily Shaffer wrote:

Show 6 quoted lines

> 
> Good to hear from you. One comment - the subject of your mail is "[RFC]"
> but I think folks are used to receiving mails with RFC patches if the
> subject line is formatted like it comes out of 'git format-patch' - that
> is, [RFC PATCH].
>

Thanks for the tip.

Show 10 quoted lines

> > 
> > "git xl" shows a graph of recent history, including all existing
> > branches (unless flagged with a config option) and their upstream
> > counterparts.  It is named such because it is easy to type and the
> > letter "x" looks like a small graph.
> 
> For me, that's not a very compelling reason to name something, and the
> only command with such a cryptic name in Git that I can think of is 'git
> am'. (mv, gc, rm, and p4 are somewhat self explanatory, and everything
> else besides 'gitk' is named with a full word.)

My thinking was that this would be a very common command, so it ought to be easy to type. It would also be learned pretty early. I can't blame you for disliking cryptic names, though. Here are some other ideas:

 - wip: for "work in progress" since it shows your repo minus upstreamed content
 - xlog: for "x" that looks like a graph (also, it sounds like "extended") and
   "log"
 - logx or log-x: for the same reason as above

I'll be working on the "ephemeral ref" portion of this as a separate work item for now, which doesn't require settling on a name immediately.

Show 7 quoted lines

> It looks like there's a decent amount of this commit message which
> really ought to be a note to the reviewers instead. Everything above the
> '---' goes into the commit message; everything below it will get
> scrubbed when the patch is applied, so you can give more casual notes
> there - for example this paragraph, as well as "Omissions I might/will
> fix".
>

Good point, I didn't know about the "---" convention, so I'll keep this in mind.

Show 6 quoted lines

> 
> If you're worried about folks using something like this in a script (and
> I would be, given that it's dynamically assigning nicknames to hashes)
> then you probably ought to mark it as a porcelain command in
> command-list.txt.
>

I've made a note to add this to command-list.txt.

Thank you, Matt