Re: [PATCH] format-patch: make format.outputDirectory relative to worktree

From: Denton Liu <liu.denton@gmail.com>
Date: Dec 24, 2019, 22:05 UTC
Message-ID: <20191224220544.GA1917@generichostname>
In-Reply-To: <xmqq36d95xwh.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Tue, Dec 24, 2019 at 11:25:18AM -0800, Junio C Hamano wrote:

Show 15 quoted lines

> Denton Liu <liu.denton@gmail.com> writes:
> > Rewrite the output directory logic for format-patch so that it will be
> > relative to the worktree of the directory. An escape hatch is provided
> > for if the previous behaviour is desired by prepending "./" to the
> > variable.
> 
> Anything that forces existing users to change their existing
> settings is not an escape hatch.  It merely is a regression with a
> possible workaround.
> 
> So I dunno.  I probably would have accepted a patch that *adds*
> outputDirectory configuration that behaves the way you are proposing
> in this patch if we did not have the variable yet in the system
> (i.e. three or four years ago), but I am not sure if it is a good
> idea to change it after these years.

Perhaps instead of switching the default behaviour so that it's always relative to the top of the worktree, we can add some sort of prefix to indicate that we want this behaviour. Maybe `worktree:path/from/top` or `^path/from/top` or something like this?

Thanks,

Denton