Re: Low prio: feature requests for git-gui

From: H.Merijn Brand <h.m.brand@xs4all.nl>
Date: Dec 23, 2019, 12:18 UTC
Message-ID: <20191223131849.13fc572e@pc09.procura.nl>
In-Reply-To: <20191222174718.nb3noztxo64g7jl3@yadavpratyush.com>

On Sun, 22 Dec 2019 23:17:18 +0530, Pratyush Yadav <me@yadavpratyush.com> wrote:

Show 6 quoted lines

> Hi Merijn,
> 
> On 20/12/19 10:42AM, H.Merijn Brand wrote:
> > • Right click context menu on file-entry in Unstaged Changes list  
> 
> It is something on my TODO list.

\o/

Show 7 quoted lines

> >   - Reset changes → git checkout this file
> >     I see the current changes need to be reversed, are bogus or
> >     invalid  
> 
> I'm not sure what this means. When you hit Ctrl-J or choose it from
> the menu bar, current changes can be reverted by checking the file
> out from the index.

I always interpreted Ctrl-J as to mean revert *all* changes. Now I know better. Thanks.

If you add it to a context menu, I'd like to have an option in setting not to get a dialog, as choosing it for a single file is (at least to me) obvious enough not to need a dialog to confirm my choice.

Show 8 quoted lines

> >   - Restore this file → git checkout this file
> >     it was accidentally removed. Like the first option  
> 
> What constitutes as "accidentally removed", and where do we restore
> the file from? If it needs to be restored from the index, then Ctrl-J
> should do the trick. If it needs to be restored from an older
> revision, well as of now git-gui doesn't have many features that deal
> with things like this. But maybe something like this can be added.

In my mind there is a difference between a changed file and a deleted file. Ctrl-J restores the previous state, which in effect is the same for both options.

Show 8 quoted lines

> >   - Remove this file from disk
> >     Somehow an invalid restore, a misplaced output or other reason
> >     (core dump, debug output from other tools) made this file appear
> >     and I don't want to add it to .gitignore  
> 
> This feature was recently added in fa38ab6 (git-gui: revert untracked 
> files by deleting them, 2019-12-01). You can hit Ctrl-J on the
> untracked file to delete it.

Yeah!

Show 5 quoted lines

> >   - Add to .gitignore
> >     Like above, but this file will re-appear more often  
> 
> A naive implementation of this shouldn't be too difficult. I'll see
> if I can find some time to do it.

Yeah! (again :)

> > Does this sound reasonable enough to make it a ticket/issue?

Thanks for the feedback

-- 
H.Merijn Brand  http://tux.nl   Perl Monger  http://amsterdam.pm.org/
using perl5.00307 .. 5.31      porting perl5 on HP-UX, AIX, and Linux
https://useplaintext.email  https://tux.nl  http://www.test-smoke.org
http://qa.perl.org   http://www.goldmark.org/jeff/stupid-disclaimers/