Re: [PATCH v2] config: add string mapping for enum config_scope

From: Jeff King <peff@peff.net>
Date: Dec 12, 2019, 03:49 UTC
Message-ID: <20191212034927.GA1200720@coredump.intra.peff.net>
In-Reply-To: <1062901d5b09d$eafbc420$c0f34c60$@gmail.com>

On Wed, Dec 11, 2019 at 10:40:37PM -0500, mattr94@gmail.com wrote:

> Just to mention, that I am working on submitting a feature to expand
> config with a --show-scope option via gitgitgadget.

That makes sense (hopefully it can be combined with --show-origin, too, to get all of the information).

> I still have some kinks to iron out before it's ready for submission,
> but maybe it would make sense to wait for that? Or to wait for the
> rest of the patches this was taken from to actually materialize?

In general, yes, I think it makes sense for a patch like this to come as part of a larger topic, that all gets merged at once. That way we don't end up with unused cruft.

It sounds like the issue is that there are two topics that use this. The simplest thing may be to have a common topic branch that both build on, but with a note never to merge it directly (that last part would be done by Junio, but the submitter would want to give that guidance along with the patch).

I _think_ that would be easy to handle with the way Junio handles the topics, but he may correct me.

-Peff