Re: [PATCH] send-pack: use OBJECT_INFO_QUICK to check negative objects

From: Jeff King <peff@peff.net>
Date: Dec 10, 2019, 20:27 UTC
Message-ID: <20191210202732.GA11733@coredump.intra.peff.net>
In-Reply-To: <CH2PR11MB4294C33B1CC956D5BF6AAB81CF5B0@CH2PR11MB4294.namprd11.prod.outlook.com>

On Tue, Dec 10, 2019 at 04:16:40PM +0000, Patrick Marlier (pamarlie) wrote:

Show 17 quoted lines

> > From: Jeff King <peff@peff.net>
> > I'll be curious to see real-world numbers from Patrick's case).
> 
> Here the real-world case (40 pushes)
> 
> released
> average 00:08:35.54
> median 00:07:37.88
> max 00:15:30.26
> 
> patched
> average 00:06:45.67
> median 00:05:39.57
> max 00:16:15.46
> 
> Note our production is using 2.19 so I back-ported the patch (need to
> include 2 other patches).

You may see much better performance if you move to 2.21 or higher, or backport the topic from 3b2f8a02fa (Merge branch 'jk/loose-object-cache', 2019-01-04). That would cause most of your negative lookups to not touch the filesystem at all.

-Peff