Re: [PATCH 01/13] ci: also run linux-gcc pipeline with python-3.7 environment
- From
SZEDER Gábor <szeder.dev@gmail.com>
- Date
- Dec 10, 2019, 10:30 UTC
- Message-ID
- <20191210103014.GF6527@szeder.dev>
- In-Reply-To
- <20191207003333.3228-2-yang.zhao@skyboxlabs.com>
On Fri, Dec 06, 2019 at 04:33:19PM -0800, Yang Zhao wrote:
Show 5 quoted lines
> git-p4.py includes support for python-3, but this was not previously > validated in CI. Lets actually do that. > > There is no tangible benefit to repeating python-3 tests for all > environments, so only limit it to linux-gcc for now.
In the subject line and the commit message body you speak about CI in general, without sinling out a particular CI system ...
> azure-pipelines.yml | 11 +++++++++++ > 1 file changed, 11 insertions(+)
... but the patch only modifies 'azure-pipelines.yml', and not '.travis.yml'.
Show 20 quoted lines
> diff --git a/azure-pipelines.yml b/azure-pipelines.yml > index 37ed7e06c6..d5f9413248 100644 > --- a/azure-pipelines.yml > +++ b/azure-pipelines.yml > @@ -331,7 +331,18 @@ jobs: > displayName: linux-gcc > condition: succeeded() > pool: Hosted Ubuntu 1604 > + strategy: > + matrix: > + python27: > + python.version: '2.7' > + python37: > + python.version: '3.7' > steps: > + - task: UsePythonVersion@0 > + inputs: > + versionSpec: '$(python.version)' > + - bash: | > + echo "##vso[task.setvariable variable=python_path]$(which python)"
I don't speak 'azure-pipelines.yml', so question: will this build Git and run the whole test suite twice, once with Python 2.7 and once with 3.7? I'm asking because 'git-p4' is the one and only Python script we have, with no plans for more, so running the whole test suite with a different Python version for a second time instead of running only the 'git-p4'-specific tests (t98*) seems to be quite wasteful.
Furthermore, this is the first patch of the series, with all the Python3 fixes in subsequent commits, so the Azure Pipelines build with Python 3.7 would fail with only this patch, wouldn't it? I think this patch should be the last in the series, after all the Python 2 vs 3 issues are sorted out.
Show 6 quoted lines
> - bash: | > test "$GITFILESHAREPWD" = '$(gitfileshare.pwd)' || ci/mount-fileshare.sh //gitfileshare.file.core.windows.net/test-cache gitfileshare "$GITFILESHAREPWD" "$HOME/test-cache" || exit 1 > > -- > 2.21.0.windows.1 >