[PATCH v3 01/14] t6120-describe: correct test repo history graph in comment
- From
SZEDER Gábor <szeder.dev@gmail.com>
- Date
- Dec 9, 2019, 11:52 UTC
- Message-ID
- <20191209115258.9281-2-szeder.dev@gmail.com>
- In-Reply-To
- <20191209115258.9281-1-szeder.dev@gmail.com>
At the top of 't6120-describe.sh' an ASCII graph illustrates the repository's history used in this test script. This graph is a bit misleading, because it swapped the second merge commit's first and second parents.
When describing/naming a commit it does make a difference which parent is the first and which is the second/Nth, so update this graph to accurately represent that second merge.
While at it, move this history graph from the 'test_description' variable to a regular comment.
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com> --- t/t6120-describe.sh | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/t/t6120-describe.sh b/t/t6120-describe.sh index 45047d0a72..9b184179d1 100755 --- a/t/t6120-describe.sh +++ b/t/t6120-describe.sh @@ -1,15 +1,16 @@ #!/bin/sh -test_description='test describe +test_description='test describe' + +# o---o-----o----o----o-------o----x +# \ D,R e / +# \---o-------------o-' +# \ B / +# `-o----o----o-' +# A c +# +# First parent of a merge commit is on the same line, second parent below. - B - .--------------o----o----o----x - / / / - o----o----o----o----o----. / - \ A c / - .------------o---o---o - D,R e -' . ./test-lib.sh check_describe () {
-- 2.24.0.801.g241c134b8d