Re: [PATCH] gitk branch name encoding utf-8 probrem

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Dec 4, 2019, 22:29 UTC
Message-ID: <20191204222921.GB195537@google.com>
In-Reply-To: <TY2PR01MB24271C32E2FD9FD8C27CA8C2CA5D0@TY2PR01MB2427.jpnprd01.prod.outlook.com>

(cc-ing Paul, gitk expert) Hi!

加藤一博 wrote:

> Here is a patch to gitk branch name utf-8 probrem.

Thanks for reporting it. Can you provide a short summary here of the problem that we can use for a self-contained description in the commit log? See https://www.kernel.org/pub/software/scm/git/docs/SubmittingPatches.html#describe-changes for more on this subject.

May we also have your sign-off? See https://www.kernel.org/pub/software/scm/git/docs/SubmittingPatches.html#sign-off for what this means.

Thanks and hope that helps, Jonathan

Show 28 quoted lines

> See issue
> https://github.com/kkato233/gitk/issues/1
> and fix it 
> https://github.com/kkato233/gitk/pull/2
> 
> 
> ---
> 
> diff --git a/gitk b/gitk
> index abe4805..3f61a5b 100755
> --- a/gitk
> +++ b/gitk
> @@ -1780,11 +1780,15 @@ proc readrefs {} {
>      global otherrefids idotherrefs mainhead mainheadid
>      global selecthead selectheadid
>      global hideremotes
> +    global tclencoding
> 
>      foreach v {tagids idtags headids idheads otherrefids idotherrefs} {
>         unset -nocomplain $v
>      }
>      set refd [open [list | git show-ref -d] r]
> +    if {$tclencoding != {}} {
> +       fconfigure $refd -encoding $tclencoding
> +    }
>      while {[gets $refd line] >= 0} {
>         if {[string index $line 40] ne " "} continue
>         set id [string range $line 0 39]