git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] packfile.c: speed up loading lots of packfiles.

From
Taylor Blau <me@ttaylorr.com>
Date
Dec 3, 2019, 06:19 UTC
Message-ID
<20191203061954.GB74594@syl.local>
In-Reply-To
<20191127222453.GA3765@owl.colinstolley.com>
Hi Colin,
On Wed, Nov 27, 2019 at 04:24:53PM -0600, Colin Stolley wrote:
Show 5 quoted lines
> When loading packfiles on start-up, we traverse the internal packfile
> list once per file to avoid reloading packfiles that have already
> been loaded. This check runs in quadratic time, so for poorly
> maintained repos with a large number of packfiles, it can be pretty
> slow.

Thanks for sending your patches to the list, and for working on this! I have been most excited to see this develop internally, and I'm glad that the new paths have been exercised enough to send the patches.

So, I'm quite interested to see what you find in terms of wiring this code up to work with khash. If that's something that you don't have time for, please do let me know and I'd be happy to take it up myself.

Other than that, this has been thoroughly reviewed internally, and so I don't have much more to add to this patch than what we have already discussed.

Thanks, Taylor

Previous: Jonathan Nieder
Message 15 of 15 in “packfile.c: speed up loading lots of packfiles.”
  1. packfile.c: speed up loading lots of packfiles.Colin Stolley, Nov 27, 2019
  2. hashmap vs khash? Re: [PATCH] packfile.c: speed up loading lots of packfiles.Eric Wong, Nov 28, 2019
  3. Junio C HamanoNov 30, 2019
  4. Jeff KingDec 2, 2019
  5. SZEDER GáborDec 2, 2019
  6. Jeff KingDec 2, 2019
  7. Taylor BlauDec 3, 2019
  8. Jeff KingDec 3, 2019
  9. Junio C HamanoDec 3, 2019
  10. Colin StolleyDec 3, 2019
  11. Jeff KingDec 3, 2019
  12. Junio C HamanoDec 4, 2019
  13. Jeff KingDec 3, 2019
  14. Jonathan NiederDec 4, 2019
  15. Taylor BlauDec 3, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.