git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/4] t/gitweb-lib.sh: set $REQUEST_URI

From
Jeff King <peff@peff.net>
Date
Nov 15, 2019, 09:06 UTC
Message-ID
<20191115090604.GC21987@sigill.intra.peff.net>
In-Reply-To
<20191115090545.GA30971@sigill.intra.peff.net>

In a real webserver's CGI call, gitweb.cgi would typically see $REQUEST_URI set. This variable does impact how we display our URL in the resulting page, so let's try to make our test as realistic as possible (we can just use the $PATH_INFO our caller passed in, if any).

This doesn't change the outcome of any tests, but it will help us add some new tests in a future patch.

Signed-off-by: Jeff King <peff@peff.net>
---
 t/gitweb-lib.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/gitweb-lib.sh b/t/gitweb-lib.sh
index 130c7ed64f..1f32ca66ea 100644
--- a/t/gitweb-lib.sh
+++ b/t/gitweb-lib.sh
@@ -60,8 +60,9 @@ gitweb_run () {
 	REQUEST_METHOD='GET'
 	QUERY_STRING=$1
 	PATH_INFO=$2
+	REQUEST_URI=/gitweb.cgi$PATH_INFO
 	export GATEWAY_INTERFACE HTTP_ACCEPT REQUEST_METHOD \
-		QUERY_STRING PATH_INFO
+		QUERY_STRING PATH_INFO REQUEST_URI
 
 	GITWEB_CONFIG=$(pwd)/gitweb_config.perl
 	export GITWEB_CONFIG
-- 
2.24.0.739.gb5632e4929
Previous: Jeff KingNext: Jeff King
Message 4 of 6 in “gitweb: quote base url more consistently”
  1. 0/4 gitweb: quote base url more consistentlyJeff King, Nov 15, 2019
  2. 1/4 t9502: pass along all arguments in xss helperJeff King, Nov 15, 2019
  3. 2/4 t/gitweb-lib.sh: drop confusing quotesJeff King, Nov 15, 2019
  4. 3/4 t/gitweb-lib.sh: set $REQUEST_URIJeff King, Nov 15, 2019
  5. 4/4 gitweb: escape URLs generated by href()Jeff King, Nov 15, 2019
  6. Junio C HamanoNov 18, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.