Re: [PATCH] t7004: check existence of correct tag

From

Jeff King <peff@peff.net>

Date

Nov 14, 2019, 06:35 UTC

Message-ID

<20191114063511.GE10643@sigill.intra.peff.net>

In-Reply-To

<20191113193902.29263-1-martin.agren@gmail.com>

On Wed, Nov 13, 2019 at 08:39:02PM +0100, Martin Ågren wrote:

> We try to delete the non-existing tag "anothertag", but for the
> verifications, we check that the tag "myhead" doesn't exist. "myhead"
> isn't used in this test except for this checking. Comparing to the test
> two tests earlier, it looks like a copy-paste mistake.

Thanks, the description and patch look good to me.

> Perhaps it's overkill to check that `git tag -d` didn't decide to
> *create* a tag. But since we're trying to be this careful, let's
> actually check the correct tag. While we're doing this, let's use a more
> descriptive tag name instead -- "nonexistingtag" should be obvious.

Yes, that would be a spectacular bug indeed. :)

-Peff