Re: [PATCH 1/1] test-tool: use 'read-graph' helper

From: Jeff King <peff@peff.net>
Date: Nov 13, 2019, 05:31 UTC
Message-ID: <20191113053151.GC3547@sigill.intra.peff.net>
In-Reply-To: <bdbc7b71884cba192c67c2bc26db5b9b3a040043.1573577900.git.gitgitgadget@gmail.com>

On Tue, Nov 12, 2019 at 04:58:20PM +0000, Derrick Stolee via GitGitGadget wrote:

Show 6 quoted lines

> From: Derrick Stolee <dstolee@microsoft.com>
> 
> The 'git commit-graph read' subcommand is used in test scripts to check
> that the commit-graph contents match the expected data. Mostly, this
> helps check the header information and the list of chunks. Users do not
> need this information, so move the functionality to a test helper.

This looks good to me.

>  t/helper/test-read-graph.c         | 53 +++++++++++++++++++++++

I wondered if we might want a commit-graph test-tool with sub-commands. But it probably doesn't matter. This would be the only thing in it. And there's less need these days to keep the number of tools down, since they're all linked into the same binary. And we can always change it later, since it's not a public interface.

So this is the simplest thing, which is probably best for now.

-Peff