Re: [PATCH 1/1] fsmonitor: fix watchman integration
On Mon, Nov 04, 2019 at 05:50:41PM +0000, Kevin Willford via GitGitGadget wrote:
Show 7 quoted lines
> When running Git commands quickly -- such as in a shell script or the
> test suite -- the Git commands frequently complete and start again
> during the same second. The example fsmonitor hooks to integrate with
> Watchman truncate the nanosecond times to seconds. In principle, this is
> fine, as Watchman claims to use inclusive comparisons [1]. The result
> should only be an over-representation of the changed paths since the
> last Git command.
> [1] https://github.com/facebook/watchman/blob/master/query/since.cpp#L35-L39
Nit: please refer to the specific blob in this link. The file's
content in 'master' might change in time, and then the highlight will
point to different lines. Worse, the file might be renamed, and then
we'll get a broken link.
SZEDER Gábor <szeder.dev@gmail.com>