Re: [PATCH 0/2] getting rid of sha1_to_hex()

From: Jeff King <peff@peff.net>
Date: Nov 11, 2019, 09:21 UTC
Message-ID: <20191111092144.GA12607@sigill.intra.peff.net>
In-Reply-To: <xmqqmud2hj9l.fsf@gitster-ct.c.googlers.com>

On Mon, Nov 11, 2019 at 06:09:10PM +0900, Junio C Hamano wrote:

Show 14 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > I happened to be looking at the oid_to_hex() family of functions today,
> > and noticed that we can drop some of the sha1-specific ones.
> >
> > It's a minor cleanup in terms of text, but it feels like a nice
> > milestone. :)
> >
> >   [1/2]: hex: drop sha1_to_hex_r()
> >   [2/2]: hex: drop sha1_to_hex()
> 
> Nice indeed.
> 
> Thanks, Brian! ;-)  oh, and Peff, of courese ;-)

I actually worried that I might be stealing brian's thunder. But AFAICT this cleanup has been waiting for almost a year, so I figured it was fair game. :)

-Peff