git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Split commit graphs and commit-graph read

From
Jeff King <peff@peff.net>
Date
Nov 11, 2019, 03:29 UTC
Message-ID
<20191111032946.GA5912@sigill.intra.peff.net>
In-Reply-To
<87f16645-6af4-9703-1d0d-eb64728d2849@gmail.com>
On Sun, Nov 10, 2019 at 08:19:20PM -0500, Derrick Stolee wrote:
Show 21 quoted lines
> > Running some tests with commands like git for-each-ref and git
> > rev-list shows that the "split" commit graph is being used (setting
> > core.commitGraph=false makes commands noticeably slower), so
> > functionally all seems well. But should git commit-graph read be
> > handling this better?
> 
> Unfortunately, you're running into an issue because I designed the
> "read" subcommand poorly (and also forgot to update it for
> incremental commit-graph files). The biggest issue is that "read"
> is not really meant for end-users. It really should have been built
> as a test-tool. This point was corrected when I got around to writing
> the multi-pack-index since it uses "test-tool read-midx" instead of
> add.
> 
> To fix this issue, I would probably go about it by removing the "read"
> subcommand and creating a "test-tool read-commit-graph" for the tests
> that need that output.
> 
> If others on-list think that the better thing to do is to update the
> "read" subcommand to provide the same output, but iterate over each
> layer of an incremental commit-graph, then I can do that work instead.

In theory I suppose one could use it to debug a commit-graph file "in the field" as it were, where somebody does not necessarily have the test-tool programs. But in practice, I have not ever done that (I didn't even know "commit-graph read" was there), and it's not that big a deal to just have a build of git.git handy.

I'd be much more likely to use "commit-graph verify". And perhaps it could grow a "--verbose" flag if somebody really wants that (but I think it would be fine to punt until somebody cares enough to do so).

I guess dropping the sub-command is technically a backwards incompatible change, but since it didn't do anything that normal users would find useful in the first place, I wouldn't be sorry to see it go.

-Peff
Previous: Junio C HamanoNext: Bryan Turner
Message 4 of 5 in “Split commit graphs and commit-graph read”
  1. Bryan TurnerNov 8, 2019
  2. Derrick StoleeNov 11, 2019
  3. Junio C HamanoNov 11, 2019
  4. Jeff KingNov 11, 2019
  5. Bryan TurnerNov 12, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.