Re: [PATCH v2] git-diff.txt: document return code of `--no-index`

From: Denton Liu <liu.denton@gmail.com>
Date: Oct 30, 2019, 22:12 UTC
Message-ID: <20191030221245.GA44961@generichostname>
In-Reply-To: <nycvar.QRO.7.76.6.1910302302060.46@tvgsbejvaqbjf.bet>

Hi Dscho,

On Wed, Oct 30, 2019 at 11:02:49PM +0100, Johannes Schindelin wrote:

Show 15 quoted lines

> > > diff --git a/Documentation/git-diff.txt b/Documentation/git-diff.txt
> > > index 72179d993c..56b396ef81 100644
> > > --- a/Documentation/git-diff.txt
> > > +++ b/Documentation/git-diff.txt
> > > @@ -36,7 +36,7 @@ two blob objects, or changes between two files on disk.
> > >    running the command in a working tree controlled by Git and
> > >    at least one of the paths points outside the working tree,
> > >    or when running the command outside a working tree
> > > -	controlled by Git.
> > > +	controlled by Git. This form implies `--no-exit`.
> >
> > s/--no-exit/--exit-code/
> 
> Oh wow. Did I really type `--no-exit` when I meant `--exit-code`? I
> guess I did. What a serious Freudian.

Nah, you're still good. The error is all mine. I wasn't paying attention when I rerolled the patch so I copied your text wrong. You initial suggestion was correct.

-Denton

Show 5 quoted lines

> 
> Thanks for pointing it out.
> 
> Ciao,
> Dscho