Re: [PATCH 3/3] myfirstcontrib: hint to find gitgitgadget allower

From: Pratyush Yadav <me@yadavpratyush.com>
Date: Oct 27, 2019, 01:39 UTC
Message-ID: <20191027013900.m7t4u6lo4tc4cdqz@yadavpratyush.com>
In-Reply-To: <20191026005159.98405-4-emilyshaffer@google.com>

On 25/10/19 05:51PM, Emily Shaffer wrote:

Show 16 quoted lines

> diff --git a/Documentation/MyFirstContribution.txt 
> b/Documentation/MyFirstContribution.txt
> index b8ffeda07e..2de06de026 100644
> --- a/Documentation/MyFirstContribution.txt
> +++ b/Documentation/MyFirstContribution.txt
> @@ -789,6 +789,14 @@ will automatically run your PRs through the CI even without the permission given
>  but you will not be able to `/submit` your changes until someone allows you to
>  use the tool.
>  
> +NOTE: You can typically find someone who can `/allow` you on GitGitGadget by
> +either examining recent pull requests where someone has been granted `/allow`
> +(https://github.com/gitgitgadget/git/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aopen+%22%2Fallow%22[Search:
> +is:pr is:open "/allow"]), in which case both the author and the person who
> +granted the `/allow` can now `/allow` you, or by inquiring on the
> +https://webchat.freenode.net/#git-devel[#git-devel] IRC channel on Freenode
> +linking your pull request and asking for someone to `/allow` you.

Nit: that's a lot to put in a single sentence. Maybe break it into parts 
like:

  NOTE: You can typically find someone who can `/allow` you on 
  GitGitGadget by looking at recent pull requests where someone has been 
  `/allow`ed. Both the author of that pull request and the person who 
  granted the permission can now `/allow` you. You can also inquire on 
  the IRC channel on Freenode linking your pull request and asking 
  someone to `/allow` you.

> +
>  If the CI fails, you can update your changes with `git rebase -i` and push your
>  branch again:

-- 
Regards,
Pratyush Yadav