Re: RFC: Moving git-gui development to GitHub
On 24/10/19 12:46PM, Elijah Newren wrote:
Show 15 quoted lines
> On Thu, Oct 24, 2019 at 2:45 AM Pratyush Yadav <me@yadavpratyush.com> wrote:
> >
> > Hi everyone,
> >
> > I recently had some discussions with Dscho about whether it is a better
> > idea to use GitHub for development instead of email [0]. His argument
> > was that GitHub makes it easier for newcomers to contribute, since more
> > people are familiar with GitHub compared to mailing lists. Also, it is
> > somewhat difficult to set up an email-based workflow.
>
> Interesting; I had been pondering asking the opposite question for
> filter-repo: Even though filter-repo is tracked externally to git.git
> (since we seem to want to move to a batteries-not-included model),
> would it be okay to ask that filter-repo contributors send patches to
> the git mailing list (possibly specially marked somehow)?
Marking them some way (like we do with git-gui) would probably be a good
idea since it allows people to just skip over those threads if they're
not interested. It also allows using email filters on those topics.
Show 22 quoted lines
> I'm debating between:
> - Ask contributors to send filter-repo patches to the git mailing
> list (if okay).
> - Try out GerritHub (GitHub + Gerrit; see gerrithub.io) and maybe use it
> - Assume there won't be many contributions (wouldn't be surprising)
> and put up with GitHub PRs
>
> GitHub is great for ease of creating new repos, learning about other
> developers, finding similar projects, creation of webhooks, etc. But
> it's *awful* for code review. Gerrit is a lot better at code reviews
> (though still has problems); so maybe dealing with both GitHub and
> Gerrit would be reasonable. (Reviewable also exists, and is kinda
> decent, but I can't respect anything that doesn't offer reviewability
> of commit messages. And it makes me feel bad by making me want to
> swat butterflies.) Email is a horrible medium for sending/receiving
> changes, but at least it gets the overall code review model right
> (commit-messages-are-first-order-objects-that-can-be-reviewed,
> review-individual-commits, merge-per-topic, cover-letter included,
> range-diff for high-level comparison of different iterations,
> reversing-commit-order-display-based-on-author-timestamps-is-NOT-forgivable,
> Change-IDs-are-ugly, magic-refs-are-disgusting, etc.), something no
> GUI tool (yet) does to my knowledge.
Thanks for your perspective. I have never really used GitHub for
anything more than one off contributions, and so never really ended up
using their review and merge tools too much. In fact, most of the open
source projects I have been interested in used mailing lists, which is
why I questioned myself if I'm biased towards such a workflow.
> So...would anyone object if I asked filter-repo contributors to send
> contributions via email to the git mailing list?
--
Regards,
Pratyush Yadav
Pratyush Yadav <me@yadavpratyush.com>