git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: cgit and global configuration

From
Christian Hesse <mail@eworm.de>
Date
Oct 25, 2019, 16:10 UTC
Message-ID
<20191025181015.50bf2b92@leda>
In-Reply-To
<20190612190845.GA14949@sigill.intra.peff.net>
Jeff King <peff@peff.net> on Wed, 2019/06/12 15:08:
Show 22 quoted lines
> On Tue, Jun 11, 2019 at 04:22:32PM -0400, Jeff Hostetler wrote:
> 
> > As for going forward, I see 3 options:
> > 
> > [1] update your tests to allow this.  (I didn't dig thru your
> >     tests to see how extensive this might be.)
> > 
> > [2] define your own version of common-main.c and link with it
> >     instead of git/common-main.c and delete the calls to trace2_*()
> >     in it.
> > 
> > [3] define your own version of common-main.c and then call your
> >     prepare_repo_env() prior to trace2_initialize().
> > 
> > Granted, I've only spent 15 minutes looking at your code, so
> > I may be mistaken about several things, but I think those are
> > your options.  
> 
> After reading the original report, my instinct was that (2) or (3) is
> probably the right way forward. We could make it a little easier for
> them by splitting up common-main a bit into two parts:
> [...]

We decided to go another way and introduced a constructor function which does initial environment setup:

https://git.zx2c4.com/cgit/commit/?id=034e3c7d56ba71ce281886fe8525b16d4559fac1
Everything (including tests) is happy with that.
-- 
Best regards,
Chris
Previous: Jeff KingNext: Jeff King
Message 5 of 6 in “cgit and global configuration”
  1. Christian HesseJun 11, 2019
  2. Junio C HamanoJun 11, 2019
  3. Jeff HostetlerJun 11, 2019
  4. Jeff KingJun 12, 2019
  5. Christian HesseOct 25, 2019
  6. Jeff KingOct 25, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.