Re: [PATCH] remote-curl: pass on atomic capability to remote side
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Oct 16, 2019, 23:43 UTC
- Message-ID
- <20191016234306.tqaszjc2sfxqg3zr@camp.crustytoothpaste.net>
- In-Reply-To
- <20191015164028.GA4710@sigill.intra.peff.net>
On 2019-10-15 at 16:40:29, Jeff King wrote:
Show 18 quoted lines
> On Tue, Oct 15, 2019 at 01:07:59AM +0000, brian m. carlson wrote:
> > diff --git a/Documentation/gitremote-helpers.txt b/Documentation/gitremote-helpers.txt
> > index a5c3c04371..670d72c174 100644
> > --- a/Documentation/gitremote-helpers.txt
> > +++ b/Documentation/gitremote-helpers.txt
> > @@ -509,6 +509,11 @@ set by Git if the remote helper has the 'option' capability.
> > Indicate that only the objects wanted need to be fetched, not
> > their dependents.
> >
> > +'option atomic' {'true'|'false'}::
> > + When pushing, request the remote server to update refs in a single atomic
> > + transaction. If successful, all refs will be updated, or none will. If the
> > + remote side does not support this capability, the push will fail.
> > +
>
> This is implemented with a single space, but the rest of the option
> bodies are indented with a tab. Asciidoc seems to format it identically
> either way, though.Yeah, my default editor configuration for AsciiDoc is two spaces. I noticed that Junio's already picked it up for next, but I'll send a v2 with this fixed in case he wants to merge the fixed version to master instead.
If it's more convenient, I can send a follow-up patch fixing the whitespace.
-- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204