git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC WIP PATCH 0/3] tag: fix --edit and --no-edit flags

From
Lucas Oshiro <lucasseikioshiro@gmail.com>
Date
Oct 8, 2019, 18:47 UTC
Message-ID
<20191008184727.14337-1-lucasseikioshiro@gmail.com>

This series of patches fixes the flags --edit and --no-edit. Currently, --no-edit has no effect.

These patches implement the following behaviour:
- when --edit is provided, the editor will always be opened;
- when --no-edit is provided, the editor will not be opened (if possible),
  otherwise an error message will be displayed;
- when neither --edit nor --no-edit are provided, the editor is opened only if
  a message is not provided and there isn't a previous tag message.

In the future, the fix of these flags and the code factoring done in this patchset will be used on the implementation of a new flag --amend, as discussed on the mail thread started on https://public-inbox.org/git/CAHd499BM6M+=zRE1WFVXr7b+VhJHFeDind5xLqXcwZLv7QeDvw@mail.gmail.com/.

Lucas Oshiro (3):
  tag: factor out tag reading from write_tag_body()
  tag: factor out prepare tag template code
  tag: add full support for --edit and --no-edit
 builtin/tag.c  | 123 ++++++++++++++++++++++++++++++++++---------------
 t/t7004-tag.sh |   4 +-
 2 files changed, 88 insertions(+), 39 deletions(-)
-- 
2.23.0
Next: Lucas Oshiro
Message 1 of 12 in “tag: fix --edit and --no-edit flags”
  1. 0/3 tag: fix --edit and --no-edit flagsLucas Oshiro, Oct 8, 2019
  2. 1/3 tag: factor out tag reading from write_tag_body()Lucas Oshiro, Oct 8, 2019
  3. Matheus Tavares BernardinoOct 9, 2019
  4. Junio C HamanoOct 10, 2019
  5. 2/3 tag: factor out prepare tag template codeLucas Oshiro, Oct 8, 2019
  6. Matheus Tavares BernardinoOct 9, 2019
  7. Junio C HamanoOct 10, 2019
  8. Junio C HamanoOct 10, 2019
  9. 3/3 tag: add full support for --edit and --no-editLucas Oshiro, Oct 8, 2019
  10. Matheus Tavares BernardinoOct 9, 2019
  11. Junio C HamanoOct 10, 2019
  12. Junio C HamanoOct 10, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.