git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] Revert "progress: use term_clear_line()"

From
Jeff King <peff@peff.net>
Date
Oct 2, 2019, 15:47 UTC
Message-ID
<20191002154734.GC6116@sigill.intra.peff.net>
In-Reply-To
<20190916205412.8602-1-szeder.dev@gmail.com>
On Mon, Sep 16, 2019 at 10:54:10PM +0200, SZEDER Gábor wrote:
Show 11 quoted lines
> > Yes on that final bit. We could always fall back to (4) if the terminal
> > information is not available, but given that the benefit is mostly in
> > simplifying the code, I don't know if it's worth carrying around _two_
> > solutions.
> 
> Ok, so here is a patch to revert 5b12e3123b (progress: use
> term_clear_line(), 2019-06-24) with proper explanation.
> 
> As a bonus there is a new test script exercising the progress display
> as well, in particular how it covers up the previous progress line, so
> we may have a bit more confidence in it.

Thanks for doing this. It's especially nice to get test coverage for the progress meters, which have traditionally been neglected.

I'm a little late on my review, as it looks like this has already hit next, but it looks pretty good to me.

My only complaint is that I think putting the new "private" bits of the progress API into the header (with a comment) is a lesser evil than re-declaring them in test-progress.c (if only because the compiler could tell us if the two get out of sync). But I can live with it either way.

-Peff
Previous: SZEDER GáborNext: Taylor Blau
Message 10 of 11 in “v2.22.1 and later regression wrt display of progress indicators”
  1. Charles DizaAug 22, 2019
  2. SZEDER GáborAug 22, 2019
  3. Jeff KingAug 22, 2019
  4. SZEDER GáborAug 22, 2019
  5. Jeff KingAug 22, 2019
  6. Taylor BlauAug 22, 2019
  7. 0/2 Revert "progress: use term_clear_line()"SZEDER Gábor, Sep 16, 2019
  8. 1/2 Revert "progress: use term_clear_line()"SZEDER Gábor, Sep 16, 2019
  9. 2/2 Test the progress displaySZEDER Gábor, Sep 16, 2019
  10. Jeff KingOct 2, 2019
  11. Taylor BlauAug 22, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.