git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] wrapper: use a loop instead of repetitive statements

From
Jeff King <peff@peff.net>
Date
Sep 27, 2019, 02:50 UTC
Message-ID
<20190927025000.GD23736@sigill.intra.peff.net>
In-Reply-To
<nycvar.QRO.7.76.6.1909262155020.15067@tvgsbejvaqbjf.bet>
On Thu, Sep 26, 2019 at 10:14:17PM +0200, Johannes Schindelin wrote:
> I mean, if there is _any_ performance-critical code path hitting this
> unrolled loop, we may want to keep it unrolled.

The loop in question is maybe a few dozen instructions, and then it immediately makes an open() syscall, which is probably multiple orders of magnitude more expensive. So I'd be very surprised if it was a problem no matter what the generated code looks like.

But...
> However, I think that this patch should at least be accompanied by a
> commit message that suggests that some thought was put into it, and that
> concerns like mine were considered carefully.
...this I would definitely agree with.
-Peff
Previous: Johannes SchindelinNext: Alex Henrie
Message 10 of 13 in “scan-build fixes”
  1. 0/3 scan-build fixesAlex Henrie, Sep 25, 2019
  2. 1/3 commit-graph: remove a duplicate assignmentAlex Henrie, Sep 25, 2019
  3. Derrick StoleeSep 26, 2019
  4. Alex HenrieSep 26, 2019
  5. 2/3 diffcore-break: use a goto instead of a redundant if statementAlex Henrie, Sep 25, 2019
  6. Derrick StoleeSep 26, 2019
  7. 3/3 wrapper: use a loop instead of repetitive statementsAlex Henrie, Sep 25, 2019
  8. Derrick StoleeSep 26, 2019
  9. Johannes SchindelinSep 26, 2019
  10. Jeff KingSep 27, 2019
  11. Alex HenrieSep 29, 2019
  12. Jeff KingSep 27, 2019
  13. Derrick StoleeSep 27, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.