git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git: use COPY_ARRAY and MOVE_ARRAY in handle_alias()

From
Jeff King <peff@peff.net>
Date
Sep 23, 2019, 22:27 UTC
Message-ID
<20190923222659.GA22645@sigill.intra.peff.net>
In-Reply-To
<d5eef24a-faa8-d6f3-c9e5-f13dc40219d4@web.de>
On Thu, Sep 19, 2019 at 10:48:30PM +0200, René Scharfe wrote:
Show 11 quoted lines
> Use the macro COPY_ARRAY to copy array elements and MOVE_ARRAY to do the
> same for moving them backwards in an array with potential overlap.  The
> result is shorter and safer, as it infers the element type automatically
> and does a (very) basic type compatibility check for its first two
> arguments.
> 
> These cases were missed by Coccinelle and contrib/coccinelle/array.cocci
> because the type of the elements is "const char *", not "char *", and
> the rules in the semantic patch cautiously insist on the sizeof operator
> being used on exactly the same type to avoid generating transformations
> that introduce subtle bugs into tricky code.
Another good reason to use "sizeof(var)" instead of sizeof(type)". :)
The patch looks good.
-Peff
Previous: René ScharfeNext: Johannes Schindelin
Message 2 of 7 in “git: use COPY_ARRAY and MOVE_ARRAY in handle_alias()”
  1. git: use COPY_ARRAY and MOVE_ARRAY in handle_alias()René Scharfe, Sep 19, 2019
  2. Jeff KingSep 23, 2019
  3. sizeof(var) vs sizeof(type), was Re: [PATCH] git: use COPY_ARRAY and MOVE_ARRAY in handle_alias()Johannes Schindelin, Sep 26, 2019
  4. Derrick StoleeSep 26, 2019
  5. SZEDER GáborSep 26, 2019
  6. Philip OakleySep 26, 2019
  7. Derrick StoleeSep 26, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.