Re: [GIT PULL] git-gui pull request

From: Denton Liu <liu.denton@gmail.com>
Date: Sep 17, 2019, 20:50 UTC
Message-ID: <20190917205051.GA63601@dentonliu-ltm.internal.salesforce.com>
In-Reply-To: <20190917201334.hfbvuisdwkwgvwg5@yadavpratyush.com>

Hi Pratyush,

Since you're the maintainer now, you should submit a patch to Documentation/SubmittingPatches to change

	- `git-gui/` comes from git-gui project, maintained by Pat Thoyts:

		git://repo.or.cz/git-gui.git

to have your own information.

On Wed, Sep 18, 2019 at 01:43:34AM +0530, Pratyush Yadav wrote:

Show 39 quoted lines

> Hi Junio,
> 
> There were some topics and discussion related to git-gui in flight. Most 
> of them have been stabilized, and merged in. So I think it's a good time 
> to pull in those changes.
> 
> ---
> The following changes since commit 
> 5ab72271e16ac23c269f5019a74a7b1d65170e47:
> 
>   Merge remote-tracking branch 'philoakley/dup-gui' (2017-03-18 15:35:09 +0000)
> 
> are available in the Git repository at:
> 
>   https://github.com/prati0100/git-gui.git 
> 
> for you to fetch changes up to f7a8834ba4aa20ec750833cf8d30d9a9fed5eade:
> 
>   Merge branch 'bp/amend-toggle-bind' (2019-09-14 23:23:12 +0530)
> 
> ----------------------------------------------------------------
> Bert Wesarg (2):
>       git-gui: convert new/amend commit radiobutton to checkbutton
>       git-gui: add horizontal scrollbar to commit buffer
> 
> Birger Skogeng Pedersen (2):
>       git-gui: add hotkeys to set widget focus
>       git-gui: add hotkey to toggle "Amend Last Commit"
> 
> Pratyush Yadav (9):
>       git-gui: allow reverting selected lines
>       git-gui: allow reverting selected hunk
>       git-gui: return early when patch fails to apply
>       git-gui: allow undoing last revert
>       Merge branch 'bp/widget-focus-hotkeys'
>       Merge branch 'py/revert-hunks-lines'
>       Merge branch 'bw/amend-checkbutton'
>       Merge branch 'bw/commit-scrollbuffer'
>       Merge branch 'bp/amend-toggle-bind'

Seems like this list is missing

	Pat Thoyts (1):
		  Merge remote-tracking branch 'philoakley/dup-gui'

	Philip Oakley (4):
		  git-gui: remove duplicate entries from .gitconfig's gui.recentrepo
		  git gui: cope with duplicates in _get_recentrepo
		  git gui: de-dup selected repo from recentrepo history
		  git gui: allow for a long recentrepo list

which should be in your PR but aren't in mainline Git yet.

Show 11 quoted lines

> 
>  git-gui.sh          | 140 ++++++++++++++++++++++++++++++++++++++++------------
>  lib/checkout_op.tcl |   6 +--
>  lib/commit.tcl      |   4 +-
>  lib/diff.tcl        |  96 +++++++++++++++++++++++++++++------
>  lib/index.tcl       |   8 +--
>  5 files changed, 199 insertions(+), 55 deletions(-)
> 
> -- 
> Regards,
> Pratyush Yadav