git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-svn: trim leading and trailing whitespaces in author name

From
Tobias Klauser <tklauser@distanz.ch>
Date
Sep 12, 2019, 11:52 UTC
Message-ID
<20190912115201.888-1-tklauser@distanz.ch>

In some cases, the svn author names might contain leading or trailing whitespaces, leading to messages such as:

  Author: user1
   not defined in authors.txt

(the trailing newline leads to the line break). The user "user1" is defined in authors.txt though, e.g.

  user1 = User <user1@example.com>

Fix this by trimming the author name retreived from svn before using it in check_author.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
 perl/Git/SVN.pm | 1 +
 1 file changed, 1 insertion(+)
diff --git a/perl/Git/SVN.pm b/perl/Git/SVN.pm
index 76b29659057d..db412c653d1d 100644
--- a/perl/Git/SVN.pm
+++ b/perl/Git/SVN.pm
@@ -1491,6 +1491,7 @@ sub call_authors_prog {
 
 sub check_author {
 	my ($author) = @_;
+	$author =~ s/^\s+|\s+$//g;
 	if (!defined $author || length $author == 0) {
 		$author = '(no author)';
 	}
-- 
2.23.0.dirty
Next: Eric Sunshine
Message 1 of 3 in “git-svn: trim leading and trailing whitespaces in author name”
  1. git-svn: trim leading and trailing whitespaces in author nameTobias Klauser, Sep 12, 2019
  2. Eric SunshineSep 12, 2019
  3. Tobias KlauserSep 12, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.