git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] commit-graph: turn off save_commit_buffer

From
Jeff King <peff@peff.net>
Date
Sep 8, 2019, 10:31 UTC
Message-ID
<20190908103118.GD15641@sigill.intra.peff.net>
In-Reply-To
<20190907185636.GB32028@syl.local>
On Sat, Sep 07, 2019 at 02:56:36PM -0400, Taylor Blau wrote:
> So, the patch here looks obviously correct, and I don't think it needs a
> test or anything like that... besides: what is there to test? :).

There's no functional change, so as long as this has coverage in the regular suite (and I think it does), there's no point in adding a new functional test.

However, it may make sense to get some coverage of commit graphs in the perf suite, so that we could detect regressions there. I think that would make sense as a separate series, though, not attached to this particular fix. (It would also be cool if the perf suite could record peak memory usage, but that would take a fair bit of refactoring).

-Peff
Previous: Taylor Blau
Message 8 of 8 in “a few commit-graph improvements”
  1. 0/2 a few commit-graph improvementsJeff King, Sep 7, 2019
  2. 1/2 commit-graph: don't show progress percentages while expanding reachable commitsJeff King, Sep 7, 2019
  3. SZEDER GáborSep 7, 2019
  4. Taylor BlauSep 7, 2019
  5. Linus TorvaldsSep 27, 2019
  6. 2/2 commit-graph: turn off save_commit_bufferJeff King, Sep 7, 2019
  7. Taylor BlauSep 7, 2019
  8. Jeff KingSep 8, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.