git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] tag: factor out get_tagged_oid()

From
Jeff King <peff@peff.net>
Date
Sep 6, 2019, 07:13 UTC
Message-ID
<20190906071320.GA14343@sigill.intra.peff.net>
In-Reply-To
<1385c954-d9ef-7ef6-6185-0dad885531ec@web.de>
On Thu, Sep 05, 2019 at 09:55:55PM +0200, René Scharfe wrote:
> Add a function for accessing the ID of the object referenced by a tag
> safely, i.e. without causing a segfault when encountering a broken tag
> where ->tagged is NULL.

This approach seems to pretty reasonable. As somebody who's been thinking about this, I'd be curious to hear your thoughts on:

  https://public-inbox.org/git/20190906065606.GC5122@sigill.intra.peff.net/

which _in theory_ means tag->tagged would never be NULL (we'd catch it at the parsing stage and consider that an error). But we'd still potentially want to protect ourselves as you do here for code paths which don't necessarily check the parse result.

-Peff
Previous: René ScharfeNext: René Scharfe
Message 3 of 6 in “tag: factor out get_tagged_oid()”
  1. 1/2 tag: factor out get_tagged_oid()René Scharfe, Sep 5, 2019
  2. 2/2 use get_tagged_oid()René Scharfe, Sep 5, 2019
  3. Jeff KingSep 6, 2019
  4. René ScharfeSep 6, 2019
  5. René ScharfeSep 6, 2019
  6. Jeff KingSep 6, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.