Re: [PATCH 1/1] fetch: add fetch.writeCommitGraph config setting
- From
Jeff King <peff@peff.net>
- Date
- Sep 4, 2019, 03:08 UTC
- Message-ID
- <20190904030829.GB28836@sigill.intra.peff.net>
- In-Reply-To
- <49f877c85ca2be5bb76d9082ee4aa26e26111a14.1567477320.git.gitgitgadget@gmail.com>
On Mon, Sep 02, 2019 at 07:22:02PM -0700, Derrick Stolee via GitGitGadget wrote:
Show 17 quoted lines
> From: Derrick Stolee <dstolee@microsoft.com> > > The commit-graph feature is now on by default, and is being > written during 'git gc' by default. Typically, Git only writes > a commit-graph when a 'git gc --auto' command passes the gc.auto > setting to actualy do work. This means that a commit-graph will > typically fall behind the commits that are being used every day. > > To stay updated with the latest commits, add a step to 'git > fetch' to write a commit-graph after fetching new objects. The > fetch.writeCommitGraph config setting enables writing a split > commit-graph, so on average the cost of writing this file is > very small. Occasionally, the commit-graph chain will collapse > to a single level, and this could be slow for very large repos. > > For additional use, adjust the default to be true when > feature.experimental is enabled.
Seems like a good time to do it. We'd eventually want a similar option for updating it on the receiving side of a push, too. I don't insist that come at the same time, but we should at least have a plan about how it will look to the user.
Do we want to to have fetch.writeCommitGraph, receive.writeCommitGraph, and then a master transfer.writeCommitGraph?
-Peff