Re: Missing file in 2.23 (p5302-pack-index.subtests)?

From: Jeff King <peff@peff.net>
Date: Aug 27, 2019, 02:27 UTC
Message-ID: <20190827022700.GA31125@sigill.intra.peff.net>
In-Reply-To: <20190827012942.GD28066@mit.edu>

On Mon, Aug 26, 2019 at 09:29:42PM -0400, Theodore Y. Ts'o wrote:

Show 11 quoted lines

> > > I presume that's becuase the file t/perf/test-results/p5302-pack-index.subtests is missing?
> > 
> > That file should be created by running p5302. If you do:
> > 
> >   cd t/perf
> >   rm -rf test-results
> >   ./run p5302-pack-index.sh
> > 
> > is it generated?
> 
> No, it wasn't.  See below....

Weird. The output here:

Show 13 quoted lines

> 1141% rm -rf test-results ; ./run p5302-pack-index.sh
> === Running 1 tests in this tree ===
> warning: $GIT_PERF_LARGE_REPO is $GIT_BUILD_DIR.
> warning: This will work, but may not be a sufficiently large repo
> warning: for representative measurements.
> not ok 1 - repack
> #	
> #		git repack -ad &&
> #		PACK=$(ls .git/objects/pack/*.pack | head -n1) &&
> #		test -f "$PACK" &&
> #		export PACK
> #	
> cannot open test-results/p5302-pack-index.subtests: No such file or directory at ./aggregate.perl line 153.

Implies that we're trying to _write_ to it, and that the problem is that test-results doesn't exist. That should be set up by this part of perf-lib:

  perf_results_dir=$TEST_OUTPUT_DIRECTORY/test-results
  test -n "$GIT_PERF_SUBSECTION" && perf_results_dir="$perf_results_dir/$GIT_PERF_SUBSECTION"
  mkdir -p "$perf_results_dir"
  rm -f "$perf_results_dir"/$(basename "$0" .sh).subtests

I don't know why that would be failing for you (and not producing any kind of message!). You might need to poke at:

  ./p5302-pack-index.sh -x

to see what is going on.

It's also weird that the repack fails for you. And that (presumably?) this is the only script that fails, since they would all want to do this.

There are some bits of test-lib.sh that re-exec the script, but I think we ironed out the weirdness there (and I use "--verbose-log" myself, which is one such option). But just in case: do you set GIT_TEST_OPTS in your config.mak?

-Peff