Re: [PATCH] diff: skip GITLINK when lazy fetching missing objs

From: Jonathan Tan <jonathantanmy@google.com>
Date: Aug 20, 2019, 21:39 UTC
Message-ID: <20190820213924.154253-1-jonathantanmy@google.com>
In-Reply-To: <xmqqblwjtu1b.fsf@gitster-ct.c.googlers.com>

Show 11 quoted lines

> Jonathan Tan <jonathantanmy@google.com> writes:
> 
> > In 7fbbcb21b1 ("diff: batch fetching of missing blobs", 2019-04-08),
> > diff was taught to batch the fetching of missing objects when operating
> > on a partial clone, but was not taught to refrain from fetching
> > GITLINKs. Teach diff to check if an object is a GITLINK before including
> > it in the set to be fetched.
> 
> OK, so in a lazy repository, running "git diff" (or "git log") could
> have resulted in "git fetch" of a history of a submodule, which may
> likely have failed?

Yes - it would attempt to fetch the submodule commit (as stated in the GITLINK) from the superproject, which is very unlikely to succeed. (And succeeding would allow the operation to continue, but will cause the superproject to have unrelated objects in its object store, which is not what we want anyway.)

> Sign-off?

Oops...here you go.

Signed-off-by: Jonathan Tan <jonathantanmy@google.com>

> Makes sense.
> 
> Thanks.

Thanks for looking at this.