git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC PATCH 2/5] line-log: remove unused fields from 'struct line_log_data'

From
SZEDER Gábor <szeder.dev@gmail.com>
Date
Aug 18, 2019, 18:27 UTC
Message-ID
<20190818182801.7580-3-szeder.dev@gmail.com>
In-Reply-To
<20190818182801.7580-1-szeder.dev@gmail.com>

Remove the unused fields 'status', 'arg_alloc', 'arg_nr' and 'args' from 'struct line_log_data'. They were already part of the struct when it was introduced in commit 12da1d1f6 (Implement line-history search (git log -L), 2013-03-28), but as far as I can tell none of them have ever been actually used.

Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
---
 line-log.h | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/line-log.h b/line-log.h
index 8ee7a2bd4a..882c5055bb 100644
--- a/line-log.h
+++ b/line-log.h
@@ -46,10 +46,7 @@ void sort_and_merge_range_set(struct range_set *);
 struct line_log_data {
 	struct line_log_data *next;
 	char *path;
-	char status;
 	struct range_set ranges;
-	int arg_alloc, arg_nr;
-	const char **args;
 	struct diff_filepair *pair;
 	struct diff_ranges diff;
 };
-- 
2.23.0.349.g73f10e387d
Previous: SZEDER GáborNext: Derrick Stolee
Message 3 of 17 in “line-log: towards a more responsive, incremental 'git log -L'”
  1. 0/5 line-log: towards a more responsive, incremental 'git log -L'SZEDER Gábor, Aug 18, 2019
  2. 1/5 completion: offer '--(no-)patch' among 'git log' optionsSZEDER Gábor, Aug 18, 2019
  3. 2/5 line-log: remove unused fields from 'struct line_log_data'SZEDER Gábor, Aug 18, 2019
  4. Derrick StoleeAug 19, 2019
  5. 3/5 t4211-line-log: add tests for parent oidsSZEDER Gábor, Aug 18, 2019
  6. 4/5 line-log: more responsive, incremental 'git log -L'SZEDER Gábor, Aug 18, 2019
  7. SZEDER GáborAug 19, 2019
  8. Derrick StoleeAug 19, 2019
  9. 5/5 line-log: try to use generation number-based topo-orderingSZEDER Gábor, Aug 18, 2019
  10. Derrick StoleeAug 19, 2019
  11. SZEDER GáborAug 19, 2019
  12. Derrick StoleeAug 19, 2019
  13. SZEDER GáborAug 19, 2019
  14. Derrick StoleeAug 19, 2019
  15. SZEDER GáborAug 21, 2019
  16. Derrick StoleeApr 9, 2020
  17. SZEDER GáborApr 24, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.