Re: [PATCH] diff: 'diff.indentHeuristic' is no longer experimental
- From
Jeff King <peff@peff.net>
- Date
- Aug 15, 2019, 13:56 UTC
- Message-ID
- <20190815135628.GA27091@sigill.intra.peff.net>
- In-Reply-To
- <20190815091245.16525-1-szeder.dev@gmail.com>
On Thu, Aug 15, 2019 at 11:12:45AM +0200, SZEDER Gábor wrote:
Show 13 quoted lines
> The indent heuristic started out as experimental, but it's now our > default diff heuristic since 33de716387 (diff: enable indent heuristic > by default, 2017-05-08). Alas, that commit didn't update the > documentation, and the description of the 'diff.indentHeuristic' > configuration variable still implies that it's experimental and not > the default. > > Update the description of 'diff.indentHeuristic' to make it clear that > it's the default diff heuristic. > > The description of the related '--indent-heuristic' option has already > been updated in bab76141da (diff: --indent-heuristic is no > longer experimental, 2017-10-29).
Yeah, this makes perfect sense.
I wondered briefly if we needed to distinguish between plumbing and porcelain here, but the config option (and its default) are the same for both.
-Peff