git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH] http: use xmalloc with cURL

From
Jeff King <peff@peff.net>
Date
Aug 14, 2019, 16:01 UTC
Message-ID
<20190814160130.GD12093@sigill.intra.peff.net>
In-Reply-To
<nycvar.QRO.7.76.6.1908132200110.656@tvgsbejvaqbjf.bet>
On Tue, Aug 13, 2019 at 10:00:44PM +0200, Johannes Schindelin wrote:
Show 10 quoted lines
> > Jeff King <peff@peff.net> writes:
> >
> > > I think it might be worth just eliminating the whole idea.
> >
> > I kinda like the simplification ;-) An even thinner wrapper that
> > calls malloc() and dies if it gets NULL, without any "try-to-free"
> > logic.
> 
> This is one of those instances where I wish we would have some reliable
> data rather than having to guess whether it is a good idea or not.

I wish we did, too. If you have an idea how to collect such data, I'm all ears.

In the absence of that, I've made an argument that it's probably the right thing to do, and we can see if cooking it over a release cycle introduces any complaints. That's far from perfect (in particular, I wouldn't be surprised if very few 32-bit users test non-releases), but I don't have other ideas.

-Peff
Previous: Johannes Schindelin
Message 11 of 11 in “http: use xmalloc with cURL”
  1. http: use xmalloc with cURLCarlo Marcelo Arenas Belón, Aug 10, 2019
  2. Daniel StenbergAug 10, 2019
  3. Carlo ArenasAug 10, 2019
  4. Johannes SchindelinAug 11, 2019
  5. Carlo ArenasAug 11, 2019
  6. Johannes SchindelinAug 12, 2019
  7. Jeff KingAug 12, 2019
  8. Junio C HamanoAug 12, 2019
  9. Jeff KingAug 12, 2019
  10. Johannes SchindelinAug 13, 2019
  11. Jeff KingAug 14, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.