git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 10/11] completion: complete config variables names and values for 'git clone -c'

From
SZEDER Gábor <szeder.dev@gmail.com>
Date
Aug 13, 2019, 12:26 UTC
Message-ID
<20190813122652.16468-11-szeder.dev@gmail.com>
In-Reply-To
<20190813122652.16468-1-szeder.dev@gmail.com>

The previous commits taught the completion script how to complete configuration section, variable names, and their valus after 'git -c <TAB>', and with a bit of foresight encapsulated all that in a dedicated helper function. Use that function to complete the unstuck argument of 'git config -c|--config <TAB>', which expect configuration variables and values in the same 'section.name=value' form.

Note that handling the struck argument for 'git clone --config=<TAB>' requires some extra care, so it will be done a separate patch.

Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
---
 contrib/completion/git-completion.bash | 6 ++++++
 1 file changed, 6 insertions(+)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 6f2bc60707..279f04df87 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1399,6 +1399,12 @@ _git_clean ()
 
 _git_clone ()
 {
+	case "$prev" in
+	-c|--config)
+		__git_complete_config_variable_name_and_value
+		return
+		;;
+	esac
 	case "$cur" in
 	--*)
 		__gitcomp_builtin clone

-- 
2.23.0.rc2.350.gf4fdc32db7
Previous: SZEDER GáborNext: SZEDER Gábor
Message 11 of 12 in “completion: complete configuration variables and values after 'git -c <TAB>'”
  1. 00/11 completion: complete configuration variables and values after 'git -c <TAB>'SZEDER Gábor, Aug 13, 2019
  2. 01/11 completion: fix a typo in a commentSZEDER Gábor, Aug 13, 2019
  3. 02/11 completion: complete more values of more 'color.*' configuration variablesSZEDER Gábor, Aug 13, 2019
  4. 04/11 completion: deduplicate configuration sectionsSZEDER Gábor, Aug 13, 2019
  5. 03/11 completion: add tests for 'git config' completionSZEDER Gábor, Aug 13, 2019
  6. 05/11 completion: use 'sort -u' to deduplicate config variable namesSZEDER Gábor, Aug 13, 2019
  7. 07/11 completion: split _git_config()SZEDER Gábor, Aug 13, 2019
  8. 06/11 completion: simplify inner 'case' pattern in __gitcomp()SZEDER Gábor, Aug 13, 2019
  9. 08/11 completion: complete configuration sections and variable names for 'git -c'SZEDER Gábor, Aug 13, 2019
  10. 11/11 completion: complete config variables and values for 'git clone --config='SZEDER Gábor, Aug 13, 2019
  11. 10/11 completion: complete config variables names and values for 'git clone -c'SZEDER Gábor, Aug 13, 2019
  12. 09/11 completion: complete values of configuration variables after 'git -c var='SZEDER Gábor, Aug 13, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.