git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 3/5] fetch: Add the fetch.jobs config key

From
Palmer Dabbelt <palmer@sifive.com>
Date
Aug 12, 2019, 21:34 UTC
Message-ID
<20190812213448.2649-4-palmer@sifive.com>
In-Reply-To
<20190812213448.2649-1-palmer@sifive.com>

This allows users to default to parallel fetches, so they don't have to pass --fetch-jobs=N on the command line every time. The implementation matches submodule.fetchjobs by die()ing on invalid job counts.

I couldn't find any documentation for submodule.fetchjobs, so I didn't write any for this one. I've tested this in my config and in conjunction with the command-line argument.

Signed-off-by: Palmer Dabbelt <palmer@sifive.com>
---
 builtin/fetch.c | 7 +++++++
 1 file changed, 7 insertions(+)
diff --git a/builtin/fetch.c b/builtin/fetch.c
index fa12ad44e7d9..4c5f2ea3a931 100644
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -104,6 +104,13 @@ static int git_fetch_config(const char *k, const char *v, void *cb)
 		return 0;
 	}
 
+	if (!strcmp(k, "fetch.jobs")) {
+		max_children_for_fetch = git_config_int(k, v);
+		if (max_children_for_fetch < 0)
+			die(_("negative values not allowed for fetch.jobs"));
+		return 0;
+	}
+
 	return git_default_config(k, v, cb);
 }
 
-- 
2.21.0
Previous: Eric WongNext: Palmer Dabbelt
Message 5 of 14 in “fetch: Extend --jobs to multiple remotes”
  1. 0/5 fetch: Extend --jobs to multiple remotesPalmer Dabbelt, Aug 12, 2019
  2. 1/5 fetch: Rename max_children to max_children_for_submodulesPalmer Dabbelt, Aug 12, 2019
  3. 2/5 fetch: Add the "--fetch-jobs" optionPalmer Dabbelt, Aug 12, 2019
  4. Eric WongAug 13, 2019
  5. 3/5 fetch: Add the fetch.jobs config keyPalmer Dabbelt, Aug 12, 2019
  6. 4/5 fetch: Add the --submodule-fetch-jobs optionPalmer Dabbelt, Aug 12, 2019
  7. 5/5 fetch: Make --jobs control submodules and remotesPalmer Dabbelt, Aug 12, 2019
  8. Johannes SchindelinAug 13, 2019
  9. Palmer DabbeltAug 13, 2019
  10. Junio C HamanoAug 13, 2019
  11. Palmer DabbeltAug 13, 2019
  12. SZEDER GáborAug 14, 2019
  13. Junio C HamanoAug 14, 2019
  14. Palmer DabbeltAug 14, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.