git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] sha1-file: release strbuf after use

From
Jeff King <peff@peff.net>
Date
Aug 7, 2019, 12:49 UTC
Message-ID
<20190807124859.GA5384@sigill.intra.peff.net>
In-Reply-To
<fa6ccb9f-11cd-7eec-fdbb-2de6a0bfcecf@web.de>
On Wed, Aug 07, 2019 at 01:15:25PM +0200, René Scharfe wrote:
Show 8 quoted lines
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
> Patch generated with --function-context for easier review.
> 
> The plugged leak was added by a10a17877b (for_each_alternate_ref:
> replace transport code with for-each-ref, 2017-02-08) and showed up in
> 709dfa6990 (object-store.h: move for_each_alternate_ref() from
> transport.h, 2019-07-01), where it caught my eye, belatedly.

Thanks, the patch obviously looks good (though I wouldn't be sad for some of your digging above to go into the commit message).

I had a vague feeling that we had seen this particular leak before (and presumably the fix fell through the cracks). But I couldn't find it on the list. I think after a while these strbuf_getline() leaks all start to look the same. :)

-Peff
Previous: René ScharfeNext: Derrick Stolee
Message 2 of 3 in “sha1-file: release strbuf after use”
  1. sha1-file: release strbuf after useRené Scharfe, Aug 7, 2019
  2. Jeff KingAug 7, 2019
  3. Derrick StoleeAug 7, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.