[PATCH 1/3] t1309: use short branch name in includeIf.onbranch test
- From
Jeff King <peff@peff.net>
- Date
- Aug 6, 2019, 12:26 UTC
- Message-ID
- <20190806122645.GA13513@sigill.intra.peff.net>
- In-Reply-To
- <20190806122601.GA21475@sigill.intra.peff.net>
Commit 85fe0e800c (config: work around bug with includeif:onbranch and early config, 2019-07-31) tests that our early config-reader does not access the file mentioned by includeIf.onbranch:refs/heads/master.path. But it would never do so even if the feature were implemented, since the onbranch matching code uses the short refname "master".
The test still serves its purpose, since the bug fixed by 85fe0e800c is actually that we hit a BUG() before even deciding whether to match the ref. But let's use the correct name to avoid confusion (and which we'll eventually want to trigger once we do the "real" fix described in that commit).
Signed-off-by: Jeff King <peff@peff.net> --- t/t1309-early-config.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t1309-early-config.sh b/t/t1309-early-config.sh index 0c37e7180d..eeb60e4143 100755 --- a/t/t1309-early-config.sh +++ b/t/t1309-early-config.sh @@ -91,7 +91,7 @@ test_expect_failure 'ignore .git/ with invalid config' ' test_expect_success 'early config and onbranch' ' echo "[broken" >broken && - test_with_config "[includeif \"onbranch:refs/heads/master\"]path=../broken" + test_with_config "[includeif \"onbranch:master\"]path=../broken" ' test_done
-- 2.23.0.rc1.436.g24d2e81391