[PATCH v2] checkout.c: unstage empty deleted ita files
- From
Varun Naik <vcnaik94@gmail.com>
- Date
- Aug 1, 2019, 16:07 UTC
- Message-ID
- <20190801160756.12601-1-vcnaik94@gmail.com>
- In-Reply-To
- <20190726045645.2437-1-vcnaik94@gmail.com>
It is possible to delete a committed file from the index and then add it as intent-to-add. After `git checkout HEAD`, the file should be identical in the index and HEAD. The command already works correctly if the file has contents in HEAD. This patch provides the desired behavior even when the file is empty in HEAD.
`git checkout HEAD` calls tree.c:read_tree_1(), with fn pointing to checkout.c:update_some(). update_some() creates a new cache entry but discards it when its mode and oid match those of the old entry. A cache entry for an ita file and a cache entry for an empty file have the same oid. Therefore, an empty deleted ita file previously passed both of these checks, and the new entry was discarded, so the file remained unchanged in the index. After this fix, if the file is marked as ita in the cache, then we avoid discarding the new entry and add the new entry to the cache instead.
This change should not affect newly added ita files. For those, inside tree.c:read_tree_1(), tree_entry_interesting() returns entry_not_interesting, so fn is never called.
Helped-by: Jeff King <peff@peff.net> Signed-off-by: Varun Naik <vcnaik94@gmail.com> --- This patch fixes and tests only "checkout", because "restore" has not reached maint yet. A second patch on the merge of this patch into master with a test case for "restore" is coming.
builtin/checkout.c | 1 + t/t2022-checkout-paths.sh | 11 +++++++++++ 2 files changed, 12 insertions(+)
diff --git a/builtin/checkout.c b/builtin/checkout.c index ffa776c6e1..c41dfa53a9 100644 --- a/builtin/checkout.c +++ b/builtin/checkout.c @@ -105,6 +105,7 @@ static int update_some(const struct object_id *oid, struct strbuf *base, if (pos >= 0) { struct cache_entry *old = active_cache[pos]; if (ce->ce_mode == old->ce_mode && + !ce_intent_to_add(old) && oideq(&ce->oid, &old->oid)) { old->ce_flags |= CE_UPDATE; discard_cache_entry(ce); diff --git a/t/t2022-checkout-paths.sh b/t/t2022-checkout-paths.sh index fc3eb43b89..6844afafc0 100755 --- a/t/t2022-checkout-paths.sh +++ b/t/t2022-checkout-paths.sh @@ -78,4 +78,15 @@ test_expect_success 'do not touch files that are already up-to-date' ' test_cmp expect actual ' +test_expect_success 'checkout HEAD adds deleted intent-to-add file back to index' ' + echo "nonempty" >nonempty && + >empty && + git add nonempty empty && + git commit -m "create files to be deleted" && + git rm --cached nonempty empty && + git add -N nonempty empty && + git checkout HEAD nonempty empty && + git diff --cached --exit-code +' + test_done
-- 2.22.0