Re: [PATCH] log: use mailmap by default
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Jul 11, 2019, 15:19 UTC
- Message-ID
- <20190711151900.GI9224@genre.crustytoothpaste.net>
- In-Reply-To
- <20190711081958.2201-1-ariadne@dereferenced.org>
On 2019-07-11 at 08:19:58, Ariadne Conill wrote:
Show 10 quoted lines
> The `git log` command shows the author and committer name recorded in > the git repository itself, while other commands respect `.mailmap` > by default. I believe this is a bad design: it causes log entries to > reflect inaccurate information: anyone who changes their name or > e-mail address will not have that change (recorded in mailmap file) > reflected when using `git log` by default. > > Anyone who explicitly wants the current behaviour can clearly request > it by setting the `log.mailmap` setting to `false` in their > `.gitconfig` file.
While I'm in favor of using the mailmap by default, typically we want a way people can override a default setting from the command line.
So in this case, we have "--use-mailmap", but we don't have a "--no-use-mailmap" (at least, it's not documented in the manpage). I think we'd want to add such an option so that people can set it if they need non-default behavior.
-- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204