git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v1.1] ci/lib.sh: update a comment about installed P4 and Git-LFS versions

From
SZEDER Gábor <szeder.dev@gmail.com>
Date
Jul 6, 2019, 16:21 UTC
Message-ID
<20190706162114.21169-1-szeder.dev@gmail.com>
In-Reply-To
<20190706161648.20836-1-szeder.dev@gmail.com>

A comment in 'ci/lib.sh' claims that the "OS X build installs the latest available versions" of P4 and Git-LFS, but since 02373e56bd (ci: don't update Homebrew, 2019-07-03) that's no longer the case, as it will install the versions which were recorded in the image's Homebrew database when the image was created.

Update this comment accordingly.
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
---

Sigh... Same patch as before, but corrected a grammar error in the commit message.

 ci/lib.sh | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/ci/lib.sh b/ci/lib.sh
index 288a5b3884..0c7171a173 100755
--- a/ci/lib.sh
+++ b/ci/lib.sh
@@ -163,8 +163,10 @@ linux-clang|linux-gcc)
 	export GIT_TEST_HTTPD=YesPlease
 
 	# The Linux build installs the defined dependency versions below.
-	# The OS X build installs the latest available versions. Keep that
-	# in mind when you encounter a broken OS X build!
+	# The OS X build installs much more recent versions, whichever
+	# were recorded in the Homebrew database upon creating the OS X
+	# image.
+	# Keep that in mind when you encounter a broken OS X build!
 	export LINUX_P4_VERSION="16.2"
 	export LINUX_GIT_LFS_VERSION="1.5.2"
 
-- 
2.22.0.667.g5c3548c1fe
Previous: SZEDER GáborNext: Johannes Schindelin
Message 15 of 18 in “Travis not looking so good”
  1. Johannes SchindelinMay 30, 2019
  2. brian m. carlsonJun 1, 2019
  3. SZEDER GáborJun 2, 2019
  4. Taylor BlauJun 26, 2019
  5. SZEDER GáborJun 27, 2019
  6. Junio C HamanoJun 27, 2019
  7. SZEDER GáborJun 29, 2019
  8. 1/2 ci: don't update HomebrewSZEDER Gábor, Jul 3, 2019
  9. 2/2 ci: disable Homebrew's auto cleanupSZEDER Gábor, Jul 3, 2019
  10. Johannes SchindelinJul 3, 2019
  11. Thomas BraunJul 3, 2019
  12. SZEDER GáborJul 3, 2019
  13. Junio C HamanoJul 3, 2019
  14. ci/lib.sh: update a comment about installed P4 and Git-LFS versionsSZEDER Gábor, Jul 6, 2019
  15. ci/lib.sh: update a comment about installed P4 and Git-LFS versionsSZEDER Gábor, Jul 6, 2019
  16. Johannes SchindelinJul 8, 2019
  17. Taylor BlauJul 9, 2019
  18. Junio C HamanoJul 10, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.