Re: [PATCH] gitk: fix --all behavior combined with --not

From: Heiko Voigt <hvoigt@hvoigt.net>
Date: Jul 4, 2019, 11:31 UTC
Message-ID: <20190704113114.GA52663@book.hvoigt.net>
In-Reply-To: <nycvar.QRO.7.76.6.1907041236200.44@tvgsbejvaqbjf.bet>

Hi Dscho,

On Thu, Jul 04, 2019 at 12:38:44PM +0200, Johannes Schindelin wrote:

> On Thu, 4 Jul 2019, Heiko Voigt wrote:

[...]

> > Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
> 
> Good description.

Thanks. I am actually surprised that for almost 5 years nobody noticed this. It seems either nobody is using --not this way or everyone took it as a feature that HEAD would be removed and will complain once this get released ;)

I usually use the caret notation, but I guess this time I was lazy and the dash was easier to type...

Show 18 quoted lines

> > ---
> >  gitk | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/gitk b/gitk
> > index a14d7a1..19d95cd 100755
> > --- a/gitk
> > +++ b/gitk
> > @@ -295,7 +295,7 @@ proc parseviewrevs {view revs} {
> >      if {$revs eq {}} {
> >  	set revs HEAD
> >      } elseif {[lsearch -exact $revs --all] >= 0} {
> > -	lappend revs HEAD
> > +	linsert revs 0 HEAD
> 
> For a moment, I wondered whether there is any case where `HEAD` might not
> be appropriate as first argument, but you're right, the revision parsing
> machinery allows mixing options and rev arguments.

Thanks for double checking.

> In short: this patch looks good to me.

Thanks for the quick review!

Cheers Heiko