Re: [PATCH v9 7/9] blame: add a fingerprint heuristic to match ignored lines

From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Jun 29, 2019, 17:19 UTC
Message-ID: <20190629171954.GG21574@szeder.dev>
In-Reply-To: <20190620163820.231316-8-brho@google.com>

On Thu, Jun 20, 2019 at 12:38:18PM -0400, Barret Rhoden wrote:

Show 6 quoted lines

> diff --git a/t/t8014-blame-ignore-fuzzy.sh b/t/t8014-blame-ignore-fuzzy.sh
> new file mode 100755
> index 000000000000..844396615271
> --- /dev/null
> +++ b/t/t8014-blame-ignore-fuzzy.sh
> @@ -0,0 +1,440 @@

Show 23 quoted lines

> +test_expect_success setup '
> +	{ for i in $(test_seq 2 $last_test)
> +	do
> +		# Append each line in a separate commit to make it easy to
> +		# check which original line the blame output relates to.
> +
> +		line_count=0 &&
> +		{ while IFS= read line
> +		do
> +			line_count=$((line_count+1)) &&
> +			echo "$line" >>"$i" &&
> +			git add "$i" &&
> +			test_tick &&
> +			GIT_AUTHOR_NAME="$line_count" git commit -m "$line_count"
> +		done } <"a$i"
> +	done } &&
> +
> +	{ for i in $(test_seq 2 $last_test)
> +	do
> +		# Overwrite the files with the final content.
> +		cp b$i $i &&
> +		git add $i
> +	done } &&

All three loops above have a pair of {} around them... but why? I don't think they are are necessary and the test does pass without them.