Re: [PATCH] stash: fix show referencing stash index

From: Mike Hommey <mh@glandium.org>
Date: Jun 24, 2019, 20:29 UTC
Message-ID: <20190624202908.atlphbwai7miwl3u@glandium.org>
In-Reply-To: <20190615112618.GC11340@hank.intra.tgummerer.com>

On Sat, Jun 15, 2019 at 12:26:18PM +0100, Thomas Gummerer wrote:

Show 20 quoted lines

> On 06/14, Mike Hommey wrote:
> > Hi,
> > 
> > `git stash <command> <n>` where n is a number used to work until 2.21.*.
> > It doesn't work in 2.22.0.
> > 
> > Bisection points to:
> > 
> > dc7bd382b1063303f4f45d243bff371899285acb is the first bad commit
> > commit dc7bd382b1063303f4f45d243bff371899285acb
> > Author: Paul-Sebastian Ungureanu <ungureanupaulsebastian@gmail.com>
> > Date:   Mon Feb 25 23:16:20 2019 +0000
> > 
> >     stash: convert show to builtin
> > 
> > which I guess makes sense :)
> 
> Yup, this is definitely a bug.  I think it only affected 'git stash
> show' however, and not other stash subcommands.  If not, could you
> point me to where else you saw this bug?

I confirmed pop, apply, branch, and drop are not affected.

Mike