git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG] Symbolic links break "git fast-export"?

From
Jeff King <peff@peff.net>
Date
Jun 24, 2019, 18:58 UTC
Message-ID
<20190624185835.GA11720@sigill.intra.peff.net>
In-Reply-To
<CABPp-BE8um5g98jqWawsuG2dAvO6AZcR54vrRzAkJbq+L3K6Zw@mail.gmail.com>
On Mon, Jun 24, 2019 at 06:33:38AM -0600, Elijah Newren wrote:
Show 8 quoted lines
> We should probably also make a corresponding improvement to
> fast-import; it also makes some attempts to be smart about handling
> order of modifies and deletes, but misses this case.  See commit
> 253fb5f8897d ("fast-import: Improve robustness when D->F changes
> provided in wrong order", 2010-07-09).  It'd be nice if fast-import
> could go through the list of changes, apply the deletes first, then
> the modifies -- although I'm not sure where renames go in the order
> off the top of my head.

You'd have to split the renames into separate delete/adds, since they can have a circular dependency. E.g. renaming "foo" to "bar" and "bar" to "foo", you must remove "foo" and "bar" both, and then add them back in.

-Peff
Previous: Elijah NewrenNext: Lars Schneider
Message 3 of 9 in “[BUG] Symbolic links break "git fast-export"?”
  1. Lars SchneiderJun 24, 2019
  2. Elijah NewrenJun 24, 2019
  3. Jeff KingJun 24, 2019
  4. Lars SchneiderJun 30, 2019
  5. Johannes SixtJun 30, 2019
  6. Elijah NewrenJul 1, 2019
  7. Lars SchneiderJun 30, 2019
  8. Elijah NewrenJul 1, 2019
  9. Elijah NewrenJun 24, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.