git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: 2.22.0 repack -a duplicating pack contents

From
Jeff King <peff@peff.net>
Date
Jun 23, 2019, 18:02 UTC
Message-ID
<20190623180226.GA1100@sigill.intra.peff.net>
In-Reply-To
<875zow8i85.fsf@evledraar.gmail.com>
On Sun, Jun 23, 2019 at 04:54:50PM +0200, Ævar Arnfjörð Bjarmason wrote:
Show 8 quoted lines
> I haven't looked at this for more than a couple of minutes (and don't
> have more time now), but this is almost certainly due to 36eba0323d
> ("repack: enable bitmaps by default on bare repos", 2019-03-14). Can you
> confirm when you re-run with repack.writeBitmaps=false in the config?
> 
> I.e. something in the "yes I want bitmaps" code implies "*.keep"
> semantics changing from "keep" to "replace", which is obvious in
> retrospect, since we can only have one *.bitmap per-repo.

Yeah, the .keep behavior with bitmaps is intended, though it means a funny implication for the bitmap-by-default strategy.

Basically, you never want to have .keep files if you have bitmaps turned on, and so the default for "respect .keeps" is based on whether bitmaps are in use. See ee34a2bead (repack: add `repack.packKeptObjects` config var, 2014-03-03).

I'm not sure of the right solution. For maximal backwards-compatibility, the default for bitmaps could become "if not bare and if there are no .keep files". But that would mean bitmaps sometimes not getting generated because of the problems that ee34a2bead was trying to solve.

That's probably OK, though; you can always flip the bitmap config to "true" yourself if you _must_ have bitmaps.

-Peff
Previous: Janos FarkasNext: Eric Wong
Message 4 of 20 in “2.22.0 repack -a duplicating pack contents”
  1. Janos FarkasJun 23, 2019
  2. Ævar Arnfjörð BjarmasonJun 23, 2019
  3. Janos FarkasJun 23, 2019
  4. Jeff KingJun 23, 2019
  5. Eric WongJun 23, 2019
  6. Jeff KingJun 23, 2019
  7. Ævar Arnfjörð BjarmasonJun 24, 2019
  8. Jeff KingJul 3, 2019
  9. repack: disable bitmaps-by-default if .keep files existEric Wong, Jun 28, 2019
  10. Ævar Arnfjörð BjarmasonJun 28, 2019
  11. 2/1 repack: warn if bitmaps are explicitly enabled with keep filesEric Wong, Jun 29, 2019
  12. Junio C HamanoJul 1, 2019
  13. Jeff KingJul 3, 2019
  14. Junio C HamanoJul 3, 2019
  15. Junio C HamanoJul 3, 2019
  16. Jeff KingJul 3, 2019
  17. Jeff KingJul 3, 2019
  18. Junio C HamanoJul 8, 2019
  19. SZEDER GáborJun 29, 2019
  20. repack: disable bitmaps-by-default if .keep files existEric Wong, Jun 29, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.