Re: [PATCH v2 01/10] t: add helper to convert object IDs to paths

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Jun 18, 2019, 23:03 UTC
Message-ID: <20190618230334.GC8877@genre.crustytoothpaste.net>
In-Reply-To: <c9be7464-21f3-6651-500d-14137f0f1c0f@kdbg.org>

On 2019-06-18 at 06:14:03, Johannes Sixt wrote:

Show 12 quoted lines

> Am 18.06.19 um 03:29 schrieb brian m. carlson:
> > On 2019-06-17 at 19:05:03, Johannes Schindelin wrote:
> > I'm fine making that change. The original design was because we had
> > other code that used that technique and I didn't see an obviously better
> > solution. Now you've provided one and a good justification.
> 
> Regardless of how it is implemented, I have another gripe with this
> helper: the way it must be used requires a process: $(test_out_to_path $foo)
> 
> And looking through this patch series, I see a gazillion of *new*
> process substitutions $(test_something...) and $(basename $whatever).
> Can't we do something about it?

A command substitution need not invoke another process. In fact, all of the test_oid calls operate only within the shell. The test_oid_cache and test_oid_init calls require spawning only expr, and they are typically limited to one or two per test.

Within reason, I'm happy to try to make things easier for Windows folks if I can, but it's still the case that process creation is more expensive on Windows and shell scripting is designed around process creation. My hope is that Microsoft's work on WSL will help them improve their Win32 process creation time so it's faster and this becomes less of an issue.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204