Re: [PATCH v2 3/4] rebase: fix garbled progress display with '-x'
On Fri, Jun 14, 2019 at 08:42:29PM +0200, Johannes Schindelin wrote:
Show 21 quoted lines
> > > > However, if the terminal were smart, then we would have to deal with
> > > > ANSI escape suddenly popping up...
> > >
> > > And I fear that is *exactly* what makes
> > > https://dev.azure.com/gitgitgadget/git/_build/results?buildId=10539&view=ms.vss-test-web.build-test-results-tab
> > > fail...
> >
> > Isn't it a sign of a problem in that Windows test environment that
> > it mistakenly believes that the terminal is smart, even though it has
> > been explicitly set to dumb?
>
> I investigated this today.
>
> Mind you, I still think that it is totally inappropriate for a test case
> with the title 'rebase -i respects rebase.missingCommitsCheck = warn' to
> validate the expected progress output, in particular since it verifies the
> progress on non-sophisticated terminals, i.e. the totally least
> interesting and least common scenario.
>
> In short: I stand by my suggestion to fix these tests (i.e. ignore the
> progress altogether) in a preparatory patch in your patch series.
I agree and will try to get around to it in the coming days.
> In case you are interested in the details, please read on, otherwise just
> mark this mail as read and move on.
>
> Still with me? Well, here you go, enjoy the ride.
> I hope you, dear reader, can appreciate the number of circumstances that
> had to come together to trigger this bug.
Thank you, it was both educational and entertaining :)
SZEDER Gábor <szeder.dev@gmail.com>