git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/5] completion: zsh: update installation instructions

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Jun 14, 2019, 06:50 UTC
Message-ID
<20190614065051.17774-2-felipe.contreras@gmail.com>
In-Reply-To
<20190614065051.17774-1-felipe.contreras@gmail.com>

Commit 0e5ed7cca3 wrongly changed the extension of the bash script to .zsh. The extension doesn't really matter, but it confuses people.

I've changed the text to make it clear that your zsh script goes to ~/.zsh/_git, and the bash script to ~/.git-completion.bash (or wherever you want).

Also, update the default locations of the system bash-completion.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/completion/git-completion.zsh | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/contrib/completion/git-completion.zsh b/contrib/completion/git-completion.zsh
index 886bf95d1f..b3c4588515 100644
--- a/contrib/completion/git-completion.zsh
+++ b/contrib/completion/git-completion.zsh
@@ -4,17 +4,19 @@
 #
 # Copyright (c) 2012-2013 Felipe Contreras <felipe.contreras@gmail.com>
 #
-# You need git's bash completion script installed somewhere, by default it
-# would be the location bash-completion uses.
-#
-# If your script is somewhere else, you can configure it on your ~/.zshrc:
-#
-#  zstyle ':completion:*:*:git:*' script ~/.git-completion.zsh
-#
 # The recommended way to install this script is to copy to '~/.zsh/_git', and
 # then add the following to your ~/.zshrc file:
 #
 #  fpath=(~/.zsh $fpath)
+#
+# You need git's bash completion script installed. By default bash-completion
+# uses /usr/share/bash-completion.
+#
+# If your bash completion script is somewhere else, you can configure it on
+# your ~/.zshrc:
+#
+#  zstyle ':completion:*:*:git:*' script ~/.git-completion.bash
+#
 
 complete ()
 {
@@ -31,9 +33,8 @@ if [ -z "$script" ]; then
 	local e
 	locations=(
 		$(dirname ${funcsourcetrace[1]%:*})/git-completion.bash
-		'/etc/bash_completion.d/git' # fedora, old debian
-		'/usr/share/bash-completion/completions/git' # arch, ubuntu, new debian
-		'/usr/share/bash-completion/git' # gentoo
+		'/usr/share/bash-completion/completions/git'
+		'/etc/bash_completion.d/git' # old debian
 		)
 	for e in $locations; do
 		test -f $e && script="$e" && break
-- 
2.22.0.rc2.dirty
Previous: Felipe ContrerasNext: Felipe Contreras
Message 2 of 6 in “contrib: completion: general zsh updates”
  1. 0/5 contrib: completion: general zsh updatesFelipe Contreras, Jun 14, 2019
  2. 1/5 completion: zsh: update installation instructionsFelipe Contreras, Jun 14, 2019
  3. 2/5 completion: zsh: fix for directories with spacesFelipe Contreras, Jun 14, 2019
  4. 3/5 completion: remove zsh hackFelipe Contreras, Jun 14, 2019
  5. 4/5 completion: zsh: improve main function selectionFelipe Contreras, Jun 14, 2019
  6. 5/5 completion: prompt: fix color for ZshFelipe Contreras, Jun 14, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.